From d372ed6e6baece9062448360245908c43f59b5c3 Mon Sep 17 00:00:00 2001 From: Lili Date: Mon, 27 Mar 2023 16:38:05 +0200 Subject: [PATCH] bugfix: check_apply_milestone was []ing None --- tlapbot/redeems.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tlapbot/redeems.py b/tlapbot/redeems.py index 3ca1402..3a333da 100644 --- a/tlapbot/redeems.py +++ b/tlapbot/redeems.py @@ -124,14 +124,15 @@ def check_apply_milestone_completion(db, redeem_name): current_app.logger.warning("Milestone not found in database.") current_app.logger.warning("Maybe you forgot to run the refresh-milestones CLI command " "after you added a new milestone to the config?") - progress, goal = row - if progress == goal: - cursor = db.execute( - "UPDATE milestones SET complete = TRUE WHERE name = ?", - (redeem_name,) - ) - db.commit() - return True + else: + progress, goal = row + if progress == goal: + cursor = db.execute( + "UPDATE milestones SET complete = TRUE WHERE name = ?", + (redeem_name,) + ) + db.commit() + return True return False except Error as e: current_app.logger.error(f"Error occured applying milestone completion: {e.args[0]}")